Skip to content

Move all ravendb specific ID generation out of the shared project - #5649

Merged
rbev merged 4 commits into
masterfrom
rhys/move-raven-code
Jul 28, 2026
Merged

Move all ravendb specific ID generation out of the shared project#5649
rbev merged 4 commits into
masterfrom
rhys/move-raven-code

Conversation

@rbev

@rbev rbev commented Jul 24, 2026

Copy link
Copy Markdown
Contributor
  • Moved singleton document ids into their respective RavenDB repositories
  • Moved Collection name constants into the RavenDB repositories
  • Moved ID formatters into the RavenDB repositories
  • Removed some unused code

@johnsimons johnsimons left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks reasonable to me.
I have added a few comments along the way.

Comment thread src/ServiceControl.Persistence.RavenDB/ErrorMessagesDataStore.cs Outdated
Comment thread src/ServiceControl.Persistence/Recoverability/ReclassifyErrorSettings.cs Outdated
Comment thread src/ServiceControl/Operations/ErrorIngestionFaultPolicy.cs Outdated
Comment thread src/ServiceControl.Persistence.RavenDB/ErrorMessagesDataStore.cs Outdated
@rbev
rbev requested a review from warwickschroeder July 27, 2026 08:11
@rbev
rbev force-pushed the rhys/move-raven-code branch from bb90c7f to 8eae2d4 Compare July 28, 2026 02:42
@rbev
rbev enabled auto-merge July 28, 2026 02:42
@rbev
rbev merged commit 2da6831 into master Jul 28, 2026
71 of 72 checks passed
@rbev
rbev deleted the rhys/move-raven-code branch July 28, 2026 04:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants